RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node [v4]

Emanuel Peter epeter at openjdk.org
Fri Nov 3 15:30:13 UTC 2023


On Fri, 3 Nov 2023 05:53:20 GMT, Eric Liu <eliu at openjdk.org> wrote:

>> This patch creates ReplicateNode to replace ReplicateB/S/I/L/F/DNode, like other vector nodes introduced recently, e.g., PopulateIndexNode and ReverseVNode, etc. This refers from:
>> https://mail.openjdk.org/pipermail/panama-dev/2020-April/008484.html
>> 
>> After merging these nodes, code will be easier to maintain. E.g., matching rules can be simplified.
>> 
>> Besides AArch64, this patch tries to keep other ad files as the same before, only supplies some necessary predicate. E.g., for matching rules using ReplicateB before, they are now matching Replicate with a new predicate "Matcher::vector_element_basic_type(n) == T_BYTE". This would be easy for review and lower risks.
>> 
>> [TEST]
>> x86:     Tested with option "-XX:UseAVX=0/1/2/3".
>> AArch64: Tested on SVE machine and Neon machine.
>> 
>> Full jtreg passed without new issue.
>
> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove is_invariant_vector

This now looks quite good.
I will run testing one more time, and then approve it from my side.

But I want that at least someone from intel (e.g. @jatin-bhateja) and someone from arm (e.g. @fg1417 ) reviews this.

Depending on how safe you feel about the changes in the other platforms you may want to ask people to at least build and test this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14830#pullrequestreview-1712941940


More information about the hotspot-compiler-dev mailing list