RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node [v2]
Eric Liu
eliu at openjdk.org
Mon Nov 6 01:23:08 UTC 2023
On Wed, 25 Oct 2023 10:01:16 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> @jatin-bhateja can you spell out a bit what you mean?
>> And when you mention broadcast instructions, do you mean any non Replicate instructions?
>
> @eme64, I see an opportunity for merging some integral broadcast patterns which share the operand definitions and matcher pattern, by moving predicates into macro assembler layer.
@jatin-bhateja @eme64 I think it's very x86 specifically. I don't have too much confidence changing other platforms' code. So as I mention at beginning, this patch only adds predicate on each rules to pursue lower risks. I think This's a workable way to refactor some shared code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14830#discussion_r1382701217
More information about the hotspot-compiler-dev
mailing list