RFR: 8319184: RISC-V: improve MD5 intrinsic [v2]

[Antonios Printezis]

On Mon, 6 Nov 2023 04:05:02 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes based on code review
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3964:
> 
>> 3962:                                Register a, Register b, Register c, Register d,
>> 3963:                                int k, int s, int t,
>> 3964:                                Register rtmp1) {
> 
> Could you please rename this into `rtmp` so that it will be more consistent in formal parameter naming convention?

I don't think `rtmp` is the right name either. The register holds the result of an expression the callers have calculated. I called it `rtmp1` as it was the same name as the register used in the callers to hold the result. Maybe I can call it `expr`, `partial_expr`, `expr_prefix`, or something similar?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16453#discussion_r1383505853