RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v8]

[Emanuel Peter]

On Fri, 3 Nov 2023 12:20:33 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/node.hpp line 1733:
>> 
>>> 1731: // Definition must appear after complete type definition of Unique_Node_List
>>> 1732: template <typename Callback, typename Bypass>
>>> 1733: void Node::visit_uses(Callback callback, Bypass bypass) {
>> 
>> Move this to node.cpp, then you don't need to have the `class Unique_Node_List` you added at the top.
>
> I can remove the forward declaration, but I can't move the definition to `node.cpp` as it is a function template? It doesn't compile on my system at least when I move it.

Ah. I guess you are right about that. There would be ways, but you'd have to make sure to instanciate all required templates... not worth it. Leave it here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1383566445