RFR: JDK-8319256: Print more diagnostic information when an unexpected user is found in a Phi

Mon Nov 6 18:06:57 UTC 2023

On Fri, 3 Nov 2023 18:27:08 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Can I please get some review on this PR to:
>> 
>> - Add more verification around the implementation of reduce allocation merges.
>> - Print more diagnostic information when an unexpected situation is encountered.
>> 
>> Testing: Linux x64 tier1-4, Renaissance, Dacapo and SpecJBB.
>
> src/hotspot/share/opto/escape.cpp line 373:
> 
>> 371:   }
>> 372: 
>> 373:   if (VerifyReduceAllocationMerges) {
> 
> Add `#ifdef ASSERT`

This block is already inside an `#ifdef ASSERT`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16465#discussion_r1383745998