RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node [v5]

Fei Gao fgao at openjdk.org
Tue Nov 7 06:36:34 UTC 2023


On Mon, 6 Nov 2023 12:13:26 GMT, Eric Liu <eliu at openjdk.org> wrote:

>> This patch creates ReplicateNode to replace ReplicateB/S/I/L/F/DNode, like other vector nodes introduced recently, e.g., PopulateIndexNode and ReverseVNode, etc. This refers from:
>> https://mail.openjdk.org/pipermail/panama-dev/2020-April/008484.html
>> 
>> After merging these nodes, code will be easier to maintain. E.g., matching rules can be simplified.
>> 
>> Besides AArch64, this patch tries to keep other ad files as the same before, only supplies some necessary predicate. E.g., for matching rules using ReplicateB before, they are now matching Replicate with a new predicate "Matcher::vector_element_basic_type(n) == T_BYTE". This would be easy for review and lower risks.
>> 
>> [TEST]
>> x86:     Tested with option "-XX:UseAVX=0/1/2/3".
>> AArch64: Tested on SVE machine and Neon machine.
>> 
>> Full jtreg passed without new issue.
>
> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update x86.ad
>   
>   Change-Id: I62328bc9c60e0131784ca441840e51ee103a15a3

Thanks for your great work! LGTM.

-------------

Marked as reviewed by fgao (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14830#pullrequestreview-1716922149


More information about the hotspot-compiler-dev mailing list