RFR: 8319615: IGV incomplete gitignore

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Nov 7 11:31:31 UTC 2023


On Tue, 7 Nov 2023 10:47:44 GMT, Daniel Lundén <duke at openjdk.org> wrote:

> This changeset adds a number of IGV-generated files to the IGV `.gitignore`.
> 
> ### Testing
> No testing as there are no code changes.

Thanks for fixing this, Daniel, I tried it out locally and it gives a clean `git status` output after building and running IGV. The fix is trivial, but please remove the extra line break before integrating.

src/utils/IdealGraphVisualizer/.gitignore line 7:

> 5: /localeVariants
> 6: /package-attrs.dat
> 7: 

Please remove this empty line.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16538#pullrequestreview-1717456151
PR Review Comment: https://git.openjdk.org/jdk/pull/16538#discussion_r1384770967


More information about the hotspot-compiler-dev mailing list