RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v3]

Dean Long dlong at openjdk.org
Wed Nov 8 07:09:00 UTC 2023


On Fri, 27 Oct 2023 21:32:46 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> These encoding classes became dead code when the instructions' definitions were patched to use the MacroAssembler.
>> 
>> Tested with tier 1-3 on Linux, Windows & MacOS.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

src/hotspot/cpu/x86/x86_64.ad line 1827:

> 1825:       cbuf.insts()->emit_int8((unsigned char) 0xE8);
> 1826:       cbuf.relocate(cbuf.insts_mark(), runtime_call_Relocation::spec(), RELOC_DISP32);
> 1827:       cbuf.insts()->emit_int32((int) ($meth$$method - ((intptr_t) cbuf.insts_end()) - 4));

Suggestion:

      __ call(RuntimeAddress(CAST_FROM_FN_PTR(address, $meth$$method)));

src/hotspot/cpu/x86/x86_64.ad line 1834:

> 1832:       __ block_comment("call JVM_EnsureMaterializedForStackWalk (elided)");
> 1833:     } else {
> 1834:       cbuf.insts()->emit_int8((unsigned char) 0xE8);

Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1386100242
PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1386101235


More information about the hotspot-compiler-dev mailing list