RFR: 8319747: galoisCounterMode_AESCrypt stack walking broken

[Vladimir Kozlov]

On Wed, 8 Nov 2023 18:11:58 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> This PR fixes stack walking by removing incorrect RBP change in the middle of a stub.
> 
> I also changed the register assignment to avoid saving RSI on Windows.
> 
> Testing:
> - test/hotspot/jtreg/compiler/codegen/aes/TestAESMain.java still passes, both on Windows and Linux
> - mach5 tier1-2 (including security and TLS-heavy networking tests) still pass
> - the generated flamegraphs (attached in JBS) show the correct stack trace with this fix

Looks good.  Please run tier3 too which will execute the test as part for `hotspot_vector_2` group with different AVX settings.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16567#pullrequestreview-1721395834