RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v5]

[Dean Long]

On Thu, 9 Nov 2023 00:05:13 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> These encoding classes became dead code when the instructions' definitions were patched to use the MacroAssembler.
>> 
>> Tested with tier 1-3 on Linux, Windows & MacOS.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo / Fix inst mark location.

src/hotspot/cpu/x86/x86_64.ad line 1834:

> 1832:       RelocationHolder rspec = _optimized_virtual ? opt_virtual_call_Relocation::spec(method_index)
> 1833:                                                   : static_call_Relocation::spec(method_index);
> 1834:       address mark = cbuf.insts()->end();

Suggestion:

      int call_offset = __ offset();

src/hotspot/cpu/x86/x86_64.ad line 1839:

> 1837:         // Calls of the same statically bound method can share
> 1838:         // a stub to the interpreter.
> 1839:         cbuf.shared_stub_to_interp_for(_method, mark - cbuf.insts()->start());

Suggestion:

        cbuf.shared_stub_to_interp_for(_method, call_offset);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1387359438
PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1387359601