RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

[Hamlin Li]

On Wed, 8 Nov 2023 19:08:29 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:

>> Hi everyone, please review this port of [AArch64](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp#L7124) `_poly1305_processBlocks` intrinsic to RISC-V platform. 
>> 
>> ### Correctness checks
>> 
>> Tier 1 tests are passed. Also I explicitly ran the `test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/Poly1305UnitTestDriver.java` test for multiple times and it passes.
>> 
>> ### Performance results on T-Head board
>> 
>> #### Results for enabled intrinsic:
>> 
>> Benchmark | (dataSize) | Mode | Cnt | Score | Error | Units
>> -- | -- | -- | -- | -- | -- | --
>> Poly1305DigestBench.digestBuffer | 64| thrpt | 3 | 247207.525 | 2853.920 | ops/s
>> Poly1305DigestBench.digestBuffer | 256 | thrpt | 3 | 221994.065 | 6891.601 | ops/s
>> Poly1305DigestBench.digestBuffer | 1024 | thrpt | 3 | 164485.375 | 4979.286 | ops/s
>> Poly1305DigestBench.digestBuffer | 16384 | thrpt | 3 | 27261.181 | 448.178 | ops/s
>> Poly1305DigestBench.digestBuffer | 1048576 | thrpt | 3 | 270.784 | 3445.077 | ops/s
>> Poly1305DigestBench.digestBytes | 64 | thrpt | 3 | 266049.018 | 9909.155 | ops/s
>> Poly1305DigestBench.digestBytes | 256 | thrpt | 3 | 231891.890 | 715.000 | ops/s
>> Poly1305DigestBench.digestBytes | 1024 | thrpt | 3 | 172746.932 | 1202.374 | ops/s
>> Poly1305DigestBench.digestBytes | 16384 | thrpt | 3 | 27626.478 | 341.915 | ops/s
>> Poly1305DigestBench.digestBytes | 1048576 | thrpt | 3 | 265.235 | 3522.458 | ops/s
>> Poly1305DigestBench.updateBytes | 64 | thrpt | 3 | 3394516.156 | 14656.687 | ops/s
>> Poly1305DigestBench.updateBytes | 256 | thrpt | 3 | 1463745.045 | 19608.937 | ops/s
>> Poly1305DigestBench.updateBytes | 1024 | thrpt | 3 | 459312.198 | 1720.655 | ops/s
>> Poly1305DigestBench.updateBytes | 16384 | thrpt | 3 | 30969.117 | 813.712 | ops/s
>> Poly1305DigestBench.updateBytes | 1048576 | thrpt | 3 | 300.773 | 3345.716 | ops/s
>> 
>> #### Results for disabled intrinsic:
>> 
>> Benchmark | (dataSize) | Mode | Cnt | Score | Error | Units
>> -- | -- | -- | -- | -- | -- | -- 
>> Poly1305DigestBench.digestBuffer | 64 | thrpt | 3 | 225424.813 | 1083.844 | ops/s
>> Poly1305DigestBench.digestBuffer | 256 | thrpt | 3 | 167848.372 | 3488.837 | ops/s
>> Poly1305DigestBench.digestBuffer | 1024 | thrpt | 3 | 81802.600 | 1839.218 | ops/s
>> Poly1305DigestBench.digestBuffer | 16384 | thrpt | 3 | 7781.049 | 1101.150 | ops/s
>> Poly1305DigestBench.digestBuffer | 1048576 | thrpt | 3 | 118.778 | 74.388 | ops/s
>> Poly1305DigestBench.digestBytes | 64 | thrpt | 3 | 23510...
>
> ArsenyBochkarev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Rename poly1305-specific functions
>  - Add final conditional reduce

Several other minor comments below

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4482:

> 4480: 
> 4481:   // Poly1305, RFC 7539
> 4482:   // Intrinsified version of com.sun.crypto.provider.Poly1305.processMultipleBlocks

It will be better if the full signature of processMultipleBlocks can be put here.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4528:

> 4526:     Label DONE, LOOP;
> 4527: 
> 4528:     __ mv(t1, checked_cast<u1>(BLOCK_LENGTH));

Is it necessary for riscv to have a `checked_cast<u1>` for the immediates?

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4569:

> 4567:       poly1305_reduce(U_2, U_1, U_0, t1, t2);
> 4568: 
> 4569:       __ sub(length, length, checked_cast<u1>(BLOCK_LENGTH));

same comments for checked_cast<u1>  as above.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4570:

> 4568: 
> 4569:       __ sub(length, length, checked_cast<u1>(BLOCK_LENGTH));
> 4570:       __ addi(input_start, input_start, 2 * wordSize);

Is this `2 * wordSize` == `BLOCK_LENGTH`? If it is,  can we use BLOCK_LENGTH instead here? as the `sub` and `addi` are related to each other via the `input` parameter.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4571:

> 4569:       __ sub(length, length, checked_cast<u1>(BLOCK_LENGTH));
> 4570:       __ addi(input_start, input_start, 2 * wordSize);
> 4571:       __ mv(t1, checked_cast<u1>(BLOCK_LENGTH));

same comments for checked_cast<u1>  as above.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16417#pullrequestreview-1722299830
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1387875980
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1387856403
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1387856764
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1387855217
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1387856895