RFR: JDK-8287284: C2: loop optimization performs split_thru_phi infinitely many times [v6]

Tobias Holenstein tholenstein at openjdk.org
Fri Nov 10 09:49:16 UTC 2023


On Wed, 8 Nov 2023 12:48:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   change can_move_to_inner_loop to take LoopNode
>
> src/hotspot/share/opto/loopopts.cpp line 164:
> 
>> 162:     } else if (region->is_Loop() && i == LoopNode::LoopBackControl &&
>> 163:                n->is_Load() && can_move_to_inner_loop(n, region->as_Loop(), x)) {
>> 164:       // it is not a win if 'x' moved from an outer to an inner loop
> 
> Maybe you want to add a comment here why we only want to do it for loads.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15536#discussion_r1389162606


More information about the hotspot-compiler-dev mailing list