RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

Andrew Haley aph at openjdk.org
Fri Nov 10 10:29:06 UTC 2023


On Thu, 9 Nov 2023 11:15:12 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Rename poly1305-specific functions
>>  - Add final conditional reduce
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4528:
> 
>> 4526:     Label DONE, LOOP;
>> 4527: 
>> 4528:     __ mv(t1, checked_cast<u1>(BLOCK_LENGTH));
> 
> Is it necessary for riscv to have a `checked_cast<u1>` for the immediates?

It's not strictly necessary to assert anything. It is good practice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1389215778


More information about the hotspot-compiler-dev mailing list