RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

Andrew Haley aph at openjdk.org
Fri Nov 10 10:47:07 UTC 2023


On Fri, 10 Nov 2023 10:26:31 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4528:
>> 
>>> 4526:     Label DONE, LOOP;
>>> 4527: 
>>> 4528:     __ mv(t1, checked_cast<u1>(BLOCK_LENGTH));
>> 
>> Is it necessary for riscv to have a `checked_cast<u1>` for the immediates?
>
> It's not strictly necessary to assert anything. It is good practice.

Ah: maybe RISC-V doesn't need it; AArch64 does.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1389233697


More information about the hotspot-compiler-dev mailing list