RFR: JDK-8287284: C2: loop optimization performs split_thru_phi infinitely many times [v3]

Fri Nov 10 11:36:00 UTC 2023

On Fri, 10 Nov 2023 10:55:49 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> > > > I am ready to integrate. Do you agree @rwestrel ?
> > > 
> > > 
> > > What about a test case?
> > 
> > 
> > right! I added one now
> 
> Does that test case cause a crash with the current jdk code? We used to have an assert on the number of rounds of loop opts but we don't have it anymore AFAICT.

If not, you could think about adding an IR test that checks that we are not adding too many phis/loads. It's not perfect but at least something.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15536#issuecomment-1805572691