RFR: 8319850: PrintInlining should report late inlines

[Joshua Cao]

On Fri, 10 Nov 2023 07:45:38 GMT, Joshua Cao <duke at openjdk.org> wrote:

> I'm not 100% sure if this covers all case of late inlines.
> 
> Passes jtreg tier1 locally on my Linux machine with a fastdebug build. With sample Java programs and -XX:+PrintInlining, I can see
> 
> 
> @ 15   java.lang.Float::valueOf (9 bytes)   late inline (boxing method)

I can see why its confusing. I reworded the JBS title and added more to the summary. 


This confused me when first starting looking at compilation units. I would see a method reported as inlined, but in the early compilation phases, I still see the method call. I was not aware of late inlines. I think it would be a nice enhancement for PrintInlining to report which methods are late inlined.


Yes, `PrintInlining` reports late inlines, but I think it would be nice for it to explicitly state which inlines are late inlines.

> There's an open bug to clean it up: https://bugs.openjdk.org/browse/JDK-8039555 FWIW, I gave it a try at some point but I couldn't find a better solution.

I can echo this issue, the inlining code does feel a little messy. I hope this patch does not make it worse, I'd say it keeps the messiness the same.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16595#issuecomment-1806471884