RFR: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K) [v5]

[Daniel Lundén]

On Mon, 6 Nov 2023 09:23:36 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tidy up check for max non_nmethod_size
>
> src/hotspot/share/code/codeCache.cpp line 327:
> 
>> 325:   // If large page support is enabled, align code heaps according to large
>> 326:   // page size to make sure that code cache is covered by large pages.
>> 327:   const size_t alignment = min_size;
> 
> Just a suggestion: I think it would be clearer to simply remove `alignment` and replace it with `min_size` below.

Thanks, removed. I also updated the comment above to clarify the connection between alignment and min_size.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16373#discussion_r1390754362