RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

[ArsenyBochkarev]

On Thu, 9 Nov 2023 11:33:49 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Rename poly1305-specific functions
>>  - Add final conditional reduce
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4482:
> 
>> 4480: 
>> 4481:   // Poly1305, RFC 7539
>> 4482:   // Intrinsified version of com.sun.crypto.provider.Poly1305.processMultipleBlocks
> 
> It will be better if the full signature of processMultipleBlocks can be put here.

Done.

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4570:
> 
>> 4568: 
>> 4569:       __ sub(length, length, checked_cast<u1>(BLOCK_LENGTH));
>> 4570:       __ addi(input_start, input_start, 2 * wordSize);
> 
> Is this `2 * wordSize` == `BLOCK_LENGTH`? If it is,  can we use BLOCK_LENGTH instead here? as the `sub` and `addi` are related to each other via the `input` parameter.

Yes, we can. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1390843591
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1390843151