RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v13]

[Daniel Lundén]

On Mon, 13 Nov 2023 09:34:03 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make visit_uses and visit_uncasted_uses const member functions
>
> src/hotspot/share/opto/node.hpp line 1145:
> 
>> 1143:      visit_uses(callback, [](Node* n){ return !n->is_ConstraintCast(); });
>> 1144:   }
>> 1145: 
> 
> `visit_uncasted_uses` is only used once, I think it would be better to inline it in `PhaseIterGVN::add_users_to_worklist()`, for simplicity and also for symmetry with `PhaseCCP::push_and`.

I agree. @eme64 OK with you?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1391061596