RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v13]

[Daniel Lundén]

On Mon, 13 Nov 2023 09:41:44 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make visit_uses and visit_uncasted_uses const member functions
>
> src/hotspot/share/opto/node.hpp line 1738:
> 
>> 1736:   // the callback for a use more than once (if it is at some point readded to
>> 1737:   // the worklist).
>> 1738:   Unique_Node_List worklist;
> 
> I think it is preferable, for simplicity and for memory efficiency, to use a queue/stack with an explicit `VectorSet` (typically called `"visited"`) idiom for the traversal.

Thanks, now updated to explicitly use `Node_List` and `VectorSet` instead of `Unique_Node_List`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1391286605