RFR: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K) [v7]

[Daniel Lundén]

On Mon, 13 Nov 2023 10:54:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Realign comment
>>  - Fix double space in comment
>
> src/hotspot/share/code/codeCache.cpp line 236:
> 
>> 234:   // Calculate default CodeHeap sizes if not set by user
>> 235:   if (!non_nmethod_set && !profiled_set && !non_profiled_set) {
>> 236:     const size_t max_non_nmethod_size = cache_size - 2 * min_size;
> 
> Please add comment "Leave room for the other two parts of the code cache"

Thanks, added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16373#discussion_r1391304641