RFR: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"

Robbin Ehn rehn at openjdk.org
Mon Nov 13 16:48:56 UTC 2023


On Mon, 13 Nov 2023 13:17:31 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you review this patch to fix the test failure in compiler/intrinsics/TestInteger/LongUnsignedDivMod.java?
> The reason of failure is that, `UDivModI` is only supplied on x86_64.ad, so it can not find this node on riscv.
> Fix is to apply the check only on x64.
> Thanks!
> 
> 
> ## Test
> To reproduce the issue, 
> 
> jtreg -timeout:10 -retain -v1 -conc:32 -nr -javaoptions:"" -testjdk:build/linux-riscv64-server-fastdebug/images/jdk/ ./test/hotspot/jtreg/compiler/intrinsics/TestIntegerUnsignedDivMod.java ./test/hotspot/jtreg/compiler/intrinsics/TestLongUnsignedDivMod.java

I mean the other port do not either have such Node.
Instead they just skip the tests:
`* @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch=="riscv64"`

So I'm wondering if this is the best way, just skip this one test, maybe the other platforms should do the same?
Or should we also skip them all ?

An example would be UdivI, which ppc and aarch64 also seems to have.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16630#issuecomment-1808537650


More information about the hotspot-compiler-dev mailing list