RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v15]

[Daniel Lundén]

On Tue, 14 Nov 2023 08:25:47 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in comment
>
> src/hotspot/share/opto/node.hpp line 1646:
> 
>> 1644: 
>> 1645:   // The initial worklist consists of the direct uses
>> 1646:   for (DUIterator_Fast kmax, k = fast_outs(kmax); k < kmax; k++)
> 
> Add curly braces. Subtle bugs happen because people do not use brackets.

Thanks, fixed.

> src/hotspot/share/opto/node.hpp line 1654:
> 
>> 1652:     if (visited.test_set(use->_idx)) continue;
>> 1653:     // Apply callback on boundary nodes
>> 1654:     if (is_boundary(use)) callback(use);
> 
> We are supposed to always use the block curly brackets.

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1392199241
PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1392199051