RFR: 8316592: RISC-V: implement poly1305 intrinsic [v9]

Tue Nov 14 09:05:38 UTC 2023

On Tue, 14 Nov 2023 06:49:54 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:

>> Did the above derivation process consider adc(U_2, U_2, U_1HI, t1); at L4564?
>
> Oh, I missed it, thanks! However, it doesn't affect much, as far as I can see:
> in `adc(U_2, U_2, U_1HI, t1)` register `t1` is `0b1` max, so the max for `U_2` is `0b10000` --> in `poly1305_reduce` the `tmp1` max is `0b100`. Multiplying it by `0b101` we get `0b10100`, which is still ok. Or am I missing something here?

Are there any restrictions on the value of U_1HI?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1392228316