RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v19]

[Roberto Castañeda Lozano]

On Tue, 14 Nov 2023 12:11:16 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test to 4-space indentation
>
> src/hotspot/share/opto/node.hpp line 1648:
> 
>> 1646:   for (DUIterator_Fast kmax, k = fast_outs(kmax); k < kmax; k++) {
>> 1647:     Node* out = fast_out(k);
>> 1648:     if (!visited.test_set(out->_idx)) { worklist.push(out); }
> 
> Suggestion:
> 
>     visited.set(out->_idx);
>     worklist.push(out);

Please disregard this suggestion, I see now that you want to handle duplicate direct uses here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1392530436