RFR: 8319879: Stress mode to randomize incremental inlining decision
Vladimir Kozlov
kvn at openjdk.org
Tue Nov 14 17:14:34 UTC 2023
On Tue, 14 Nov 2023 07:07:30 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> > Why you switch off flag in cha/*RootMethod.java tests?
>
> They already have `-XX:-AlwaysIncrementalInline`. If incremental inlining is used, the tests fail with:
>
> ```
> Caused by: java.lang.RuntimeException: assertTrue: expected true, was false
> at jdk.test.lib.Asserts.fail(Asserts.java:634)
> at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
> at jdk.test.lib.Asserts.assertTrue(Asserts.java:472)
> at compiler.cha.Utils$ATest.assertNotCompiled(Utils.java:150)
> at compiler.cha.AbstractRootMethod$AbstractClass.test(AbstractRootMethod.java:132)
> at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> ```
I don't see `-XX:-AlwaysIncrementalInline` in these 2 tests. They have only `-XX:-StressMethodHandleLinkerInlining` which only control inlining for MH. I am not saying that adding `-XX:-StressIncrementalInlining` is wrong but I need explanation.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16597#issuecomment-1810718718
More information about the hotspot-compiler-dev
mailing list