RFR: JDK-8319784: VM crash during heap dump after JDK-8287061
Vladimir Kozlov
kvn at openjdk.org
Tue Nov 14 18:50:25 UTC 2023
On Sat, 11 Nov 2023 01:52:54 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
> This fixes an incorrect assert in `debugInfo.hpp`. The assert is incorrect because this method may be called before rematerialization of the ObjectValue takes place, and therefore, `_selected` will be nullptr. This pull request patches the method to just return `Handle() => nullptr` if the rematerialization of the object hasn't taken place yet. This is the same behavior used by scalar-replaced objects not participating in merges.
>
> I added a test to reproduce a scenario where the assert was causing a problem.
>
> Tested on Ubuntu/MacOS/Windows x86_64 tier1-4.
Looks good. You need second review.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16622#pullrequestreview-1730493358
More information about the hotspot-compiler-dev
mailing list