RFR: JDK-8318671: Potential uninitialized uintx value after JDK-8317683 [v5]

[Thomas Stuefe]

On Tue, 14 Nov 2023 15:03:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge branch 'master' into JDK-8318671-Potential-uninitialized-uintx-value-after-JDK-8317683
>>  - Fix Windows build
>>  - remove tab
>>  - Make patch more palatable
>>  - Merge branch 'openjdk:master' into JDK-8318671-Potential-uninitialized-uintx-value-after-JDK-8317683
>>  - JDK-8318671-Potential-uninitialized-uintx-value-after-JDK-8317683
>
> src/hotspot/share/compiler/compilerOracle.cpp line 678:
> 
>> 676: // Parse an uintx-based option value. Also takes care of parsing enum values for options that are enums.
>> 677: // Returns true if ok, false if the value could not be parsed.
>> 678: static bool parseUintxValue(enum CompileCommand option, const char* line, uintx& value, int& bytes_read) {
> 
> It is honestly weird to see `parse***Uintx***Value` dealing with enums, and be specialized for `MemStat`. Can you reflow this to match how `MemLimit` does it? https://github.com/openjdk/jdk/blob/7bb1999c51cdfeb020047e1094229fda1ec5a99d/src/hotspot/share/compiler/compilerOracle.cpp#L702

Okay, rewritten in the style of https://github.com/openjdk/jdk/pull/16631. Retested too. Let's get this out of the door, please.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16335#discussion_r1393696933