RFR: JDK-8319784: VM crash during heap dump after JDK-8287061

[Tobias Hartmann]

On Sat, 11 Nov 2023 01:52:54 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

> This fixes an incorrect assert in `debugInfo.hpp`. The assert is incorrect because this method may be called before rematerialization of the ObjectValue takes place, and therefore, `_selected` will be nullptr. This pull request patches the method to just return `Handle() => nullptr` if the rematerialization of the object hasn't taken place yet. This is the same behavior used by scalar-replaced objects not participating in merges.
> 
> I added a test to reproduce a scenario where the assert was causing a problem.
> 
> Tested on Ubuntu/MacOS/Windows x86_64 tier1-4.

src/hotspot/share/code/debugInfo.hpp line 235:

> 233:   int                         field_size()                    { ShouldNotReachHere(); return -1; }
> 234: 
> 235:   Handle                      value() const ;

Suggestion:

  Handle                      value() const;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16622#discussion_r1393793361