RFR: JDK-8287284: C2: loop optimization performs split_thru_phi infinitely many times [v3]

[Tobias Holenstein]

On Tue, 14 Nov 2023 09:12:30 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>>> > > > I am ready to integrate. Do you agree @rwestrel ?
>>> > > 
>>> > > 
>>> > > What about a test case?
>>> > 
>>> > 
>>> > right! I added one now
>>> 
>>> Does that test case cause a crash with the current jdk code? We used to have an assert on the number of rounds of loop opts but we don't have it anymore AFAICT.
>> 
>> You are right. I added an IR test-case now that fails without the fix. I plan to reintroduce that assert in another RFE
>
>> You are right. I added an IR test-case now that fails without the fix. I plan to reintroduce that assert in another RFE
> 
> Thanks for adding the test case. That looks good to me.

Thanks @rwestrel , @eme64 , @chhagedorn and @TobiHartmann for the reviews and discussions!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15536#issuecomment-1812009674