RFR: 8318219: RISC-V: C2 ExpandBits [v2]

Hamlin Li mli at openjdk.org
Wed Nov 15 10:27:54 UTC 2023


On Wed, 15 Nov 2023 01:44:39 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - merge master
>>  - refine comments and tests
>>  - enable TestBitShuffleOpers.java
>>  - Initial commit
>
> test/hotspot/jtreg/compiler/intrinsics/TestBitShuffleOpers.java line 34:
> 
>> 32:  *             vm.cpu.features ~= ".*sse2.*")) |
>> 33:  *            (os.arch=="aarch64" & vm.cpu.features ~= ".*svebitperm.*") |
>> 34:  *            (os.arch=="riscv64" & vm.cpu.features ~= ".*v.*"))
> 
> I think the matching for riscv64 should be: `(os.arch=="riscv64" & vm.cpu.features ~= ".*v,.*"))` as described on [JBS ](https://bugs.openjdk.org/browse/JDK-8315652) and discussed at [1].
> 
> [1] https://github.com/openjdk/jdk/pull/15579#issuecomment-1709745846

Thanks for pointing to the link!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16658#discussion_r1393987255


More information about the hotspot-compiler-dev mailing list