RFR: 8318219: RISC-V: C2 ExpandBits [v2]

Fei Yang fyang at openjdk.org
Wed Nov 15 10:48:30 UTC 2023


On Wed, 15 Nov 2023 10:27:50 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review the change to add intrinsic for ExpandBits for Long & Integer?
>> Thanks!
>> 
>> related to: https://github.com/openjdk/jdk/pull/16481
>> 
>> ## Test
>> ### jtreg
>> test/jdk/java/lang/CompressExpand*.java
>> test/hotspot/jtreg/compiler/intrinsics/TestBitShuffleOpers.java
>> test/hotspot/jtreg/compiler/intrinsics/
>> 
>> ### gtest
>> test/hotspot/gtest/opto/test_compress_expand_bits.cpp
>
> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - merge master
>  - refine comments and tests
>  - enable TestBitShuffleOpers.java
>  - Initial commit

Updated change looks good to me assuming that the modified test could still be matched and test good. Thanks.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16658#pullrequestreview-1731741971


More information about the hotspot-compiler-dev mailing list