RFR: JDK-8318444: Write details about compilation bailouts into crash reports [v4]

[Thomas Stuefe]

On Wed, 15 Nov 2023 11:40:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge branch 'master' into JDK-8318444-Write-details-about-compilation-bailouts-into-crash-reports
>>  - Update src/hotspot/share/compiler/compilationFailureInfo.hpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/utilities/vmError.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - reinstate elapsed time prefix in hs-err file
>>  - Merge branch 'openjdk:master' into JDK-8318444-Write-details-about-compilation-bailouts-into-crash-reports
>>  - wip
>>  - wip
>>  - wip
>>  - wip
>>  - JDK-8318444-Write-details-about-compilation-bailouts-into-crash-reports
>
> src/hotspot/share/compiler/compilationFailureInfo.cpp line 45:
> 
>> 43: #include "utilities/nativeCallStack.hpp"
>> 44: 
>> 45: static constexpr int skip_frames = 2;
> 
> Is there a specific reason to define this separately and not directly use `_stack(2)` below?

None but that the argument usually goes the other way around, "why do you use raw numbers, please name that constant" :-)

No problem, I can pass 2 directly.

> src/hotspot/share/opto/compile.cpp line 995:
> 
>> 993: Compile::~Compile() {
>> 994:   delete _print_inlining_stream;
>> 995:   delete _first_failure_details;
> 
> Should we first check for `nullptr` before deleting here?

delete, like free, accepts nullptr and does nothing. We delete/os::free null in many places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16247#discussion_r1394128242
PR Review Comment: https://git.openjdk.org/jdk/pull/16247#discussion_r1394130457