Integrated: 8319747: galoisCounterMode_AESCrypt stack walking broken
Daniel Jeliński
djelinski at openjdk.org
Thu Nov 16 08:58:44 UTC 2023
On Wed, 8 Nov 2023 18:11:58 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This PR fixes stack walking by removing incorrect RBP change in the middle of a stub.
>
> I also changed the register assignment to avoid saving RSI on Windows.
>
> Testing:
> - test/hotspot/jtreg/compiler/codegen/aes/TestAESMain.java still passes, both on Windows and Linux
> - mach5 tier1-2 (including security and TLS-heavy networking tests) still pass
> - the generated flamegraphs (attached in JBS) show the correct stack trace with this fix
This pull request has now been integrated.
Changeset: faeea07f
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/faeea07fe5d27e0c18c26f99705cc552e5ab9bdc
Stats: 9 lines in 1 file changed: 3 ins; 6 del; 0 mod
8319747: galoisCounterMode_AESCrypt stack walking broken
Reviewed-by: kvn, sviswanathan
-------------
PR: https://git.openjdk.org/jdk/pull/16567
More information about the hotspot-compiler-dev
mailing list