RFR: 8316592: RISC-V: implement poly1305 intrinsic [v11]

ArsenyBochkarev duke at openjdk.org
Thu Nov 16 17:10:01 UTC 2023


On Wed, 15 Nov 2023 10:15:38 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do a two-steps reduce
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4477:
> 
>> 4475:     __ srli(tmp1, U_2, 2);
>> 4476:     __ cad(U_0, U_0, tmp1, tmp2); // Add tmp1 to U_0 with carry output to tmp2
>> 4477:     __ andi(U_2, U_2, bits2); // Clear U_2 except for the first two bits
> 
> Suggestion:
> 
>     __ andi(U_2, U_2, bits2); // Clear U_2 except for the lowest two bits

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1396063512


More information about the hotspot-compiler-dev mailing list