RFR: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
Fei Yang
fyang at openjdk.org
Fri Nov 17 03:30:31 UTC 2023
On Fri, 17 Nov 2023 02:32:16 GMT, Gui Cao <gcao at openjdk.org> wrote:
> This is inspired by https://bugs.openjdk.org/browse/JDK-8316880.
> MacroAssembler::lightweight_lock/unlock is non-trivial on linux-riscv64 platform. Passing t0(aka x5) as temporary register to these two assember functions can also be error prone. As a reserved scratch register, t0 is implicitly clobberred by various assembler functions. This fixes the issue by finding and passing a different register, which is similar with https://bugs.openjdk.org/browse/JDK-8316880.
>
> ### Testing:
> - [x] Run tier1-3 tests with qemu 8.1.50 (default locking mode)
> - [x] Run non-trivial benchmark workloads (specjbb2005, dacapo, renaissance) with -XX:LockingMode=2
Looks good. Thanks for fixing this.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16703#pullrequestreview-1735980164
More information about the hotspot-compiler-dev
mailing list