RFR: 8320272: Make method_entry_barrier address shared
Vladimir Kozlov
kvn at openjdk.org
Fri Nov 17 22:39:28 UTC 2023
On Fri, 17 Nov 2023 22:09:09 GMT, Dean Long <dlong at openjdk.org> wrote:
> This seems fine, but you could explain a little more why this is useful for Leyden? I would think having StubRoutines::method_entry_barrier() would be enough, and that it could reference the existing platform-specific name, minimizing changes. I don't understand why the storage needs to be shared in StubRoutines::_method_entry_barrier, for example.
Thank you for looking, Dean. Yes, your suggestion would work too. Leyden code calls StubRoutines::method_entry_barrier() to get address: [SCCache.cpp#L3337](https://github.com/openjdk/leyden/blob/premain/src/hotspot/share/code/SCCache.cpp#L3337)
But we would need StubRoutines::method_entry_barrier() implementation for each platform in such case. And having duplication and different names does not feel right for me ;^)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16708#issuecomment-1817207215
More information about the hotspot-compiler-dev
mailing list