RFR: 8320272: Make method_entry_barrier address shared

Tom Rodriguez never at openjdk.org
Sat Nov 18 00:27:29 UTC 2023


On Fri, 17 Nov 2023 16:10:25 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Currently all platforms have declared their own address variable for method_entry_barrier stub. Some have even slightly different name: nmethod_entry_barrier. For Leyden project one address is preferable.
> In aarch64 code changed `movptr` to `lea` instruction to get relocation info as on x86.
> 
> Tested x86 and aarch64, tier1-4, xcomp, stress.  I need help to test on other platforms. Thanks!

src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp line 150:

> 148:     thread_disarmed_guard_value_offset = in_bytes(bs_nm->thread_disarmed_guard_value_offset());
> 149:     AMD64_ONLY(nmethod_entry_barrier = StubRoutines::method_entry_barrier());
> 150:     AARCH64_ONLY(nmethod_entry_barrier = StubRoutines::method_entry_barrier());

Now that's there's a single name you can remove the 2 per arch definitions in favor of single assignment statement.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16708#discussion_r1398009834


More information about the hotspot-compiler-dev mailing list