RFR: 8319822: Use a linear-time algorithm for assert_different_registers() [v5]

[Stefan Karlsson]

On Fri, 17 Nov 2023 16:08:51 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> At the present time, `assert_different_registers()` uses an O(N**2) algorithm in assert_different_registers(). We can utilize RegSet to do it in O(N) time. This would be a useful optimization for all builds with assertions enabled.
>> 
>> In addition, it would be useful to be able to static_assert different registers. 
>> 
>> Also, I've taken the opportunity to expand the maximum size of a RegSet to 64 on 64-bit platforms.
>> 
>> I also fixed a bug: sometimes `noreg` is passed to `assert_different_registers()`, but it may only be passed once or a spurious assertion is triggered.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8319822: Use a linear-time algorithm for assert_different_registers()

>From the summary:
> In addition, it would be useful to be able to static_assert different registers.

As mentioned in https://github.com/openjdk/jdk/pull/16617#issuecomment-1807933886 this doesn't work unless we make the proposed small tweak. Do you want to make it in this PR, or should I propose that in a separate PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16617#issuecomment-1818782581