RFR: 8319879: Stress mode to randomize incremental inlining decision [v3]

Tobias Hartmann thartmann at openjdk.org
Mon Nov 20 14:40:11 UTC 2023


On Mon, 20 Nov 2023 08:30:51 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved the should_delay check up
>
> src/hotspot/share/opto/callGenerator.cpp line 992:
> 
>> 990:   CallGenerator* cg = CallGenerator::for_method_handle_inline(jvms, caller, callee, allow_inline, input_not_const);
>> 991:   Compile* C = Compile::current();
>> 992:   bool should_delay = AlwaysIncrementalInline || (StressIncrementalInlining && (C->random() % 2) == 0);
> 
> Maybe this should go in its own function.

Thanks for the review, Roland! I added a new `should_delay_inlining` method to `Compile`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16597#discussion_r1399292345


More information about the hotspot-compiler-dev mailing list