RFR: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp [v2]

[Daniel Lundén]

On Mon, 20 Nov 2023 13:21:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after comments
>
> src/hotspot/share/opto/phasetype.hpp line 170:
> 
>> 168:                       _valid(true),
>> 169:                       _set(false),
>> 170:                       _bad(nullptr)
> 
> I think the colon belongs up on the same line as `PhaseNameValidator(ccstrlist option)`, and the initializations only should be indented by 2 whitespaces.

Alright, sounds good to me (now changed). The previous style is the same as for `Compile::Compile` in `compile.cpp`, but the style differs between different parts of HotSpot.

> src/hotspot/share/opto/phasetype.hpp line 198:
> 
>> 196:   }
>> 197: 
>> 198:   const BitMap& mask() const { return _mask; }
> 
> You could additionally assert `is_valid` before returning the mask, just to ensure it is never called when invalid.

Thanks, added now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1399296171
PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1399296545