RFR: 8316592: RISC-V: implement poly1305 intrinsic [v12]

ArsenyBochkarev duke at openjdk.org
Mon Nov 20 15:23:30 UTC 2023


On Fri, 17 Nov 2023 05:35:05 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comment: first -> lowest
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4419:
> 
>> 4417: #ifdef COMPILER2
>> 4418: 
>> 4419: static const int64_t bits2 = right_n_bits(2);
> 
> Suggestion: s/bits2/2bits/

Replaced to `first_2_bits`

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4420:
> 
>> 4418: 
>> 4419: static const int64_t bits2 = right_n_bits(2);
>> 4420: static const int64_t bits3 = right_n_bits(3);
> 
> Suggestion: s/bits3/3bits/

Replaced to `first_3_bits`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1399356071
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1399356037


More information about the hotspot-compiler-dev mailing list