RFR: 8316592: RISC-V: implement poly1305 intrinsic [v12]

ArsenyBochkarev duke at openjdk.org
Mon Nov 20 15:23:33 UTC 2023


On Fri, 17 Nov 2023 08:47:58 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4509:
>> 
>>> 4507: 
>>> 4508:     RegSet saved_regs = RegSet::range(x18, x21);
>>> 4509:     RegSetIterator<Register> regs = (RegSet::range(x13, x31) - RegSet::range(x22, x27)).begin();
>> 
>> I personally prefer:
>> `RegSetIterator<Register> regs = (RegSet::range(x14, x31) - RegSet::range(x22, x27)).begin();` 
>> and
>> `const Register R_0 = *regs, R_1 = *++regs;`
>> That would be more readable as `x13` aliases `c_rarg3` which is assigned to `r_start` here. But it's up to you.
>
> Agree.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1399356146


More information about the hotspot-compiler-dev mailing list