RFR: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless [v2]
Tobias Hartmann
thartmann at openjdk.org
Tue Nov 21 07:24:04 UTC 2023
On Tue, 21 Nov 2023 07:13:39 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
>> A recent improvement ([JDK-8314838](https://bugs.openjdk.org/browse/JDK-8314838)) changed dependant VM creation in that test - we now forward given arguments via 'ProcessTools.createTestJvm()'. It has been revealed, however, that the test doesn't work well with '-Xcomp'. A bug ([JDK-8316124](https://bugs.openjdk.org/browse/JDK-8316124)) has been filed.
>>
>> I suggest to temporarily make test 'vm.flagless' to allow for running the test in CI. As soon as [JDK-8316124](https://bugs.openjdk.org/browse/JDK-8316124) is fixed, we'll remove that limitation.
>
> Evgeny Nikitin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into JDK-8315969/make_TestRangeCheckHoistingScaledIV_vm_flagless/pub
> - 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
Looks good to me. Please add a comment to [JDK-8316124](https://bugs.openjdk.org/browse/JDK-8316124) to keep track of removing the limitation.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16746#pullrequestreview-1741261792
More information about the hotspot-compiler-dev
mailing list