RFR: 8320128: Clean up Parse constructor for OSR [v2]

[Tobias Hartmann]

On Tue, 21 Nov 2023 04:31:02 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/opto/parse1.cpp line 511:
>> 
>>> 509: #ifndef PRODUCT
>>> 510:       if (PrintOpto && (Verbose || WizardMode)) {
>>> 511:         if (_entry_bci != InvocationEntryBci) {
>> 
>> Suggestion:
>> 
>>         if (C->is_osr_compilation()) {
>
> This is not exactly the same. we want to execute this statement if and only if (C->is_osr_compilation() && depth() == 1)!  
> 
> 
> tty->print("OSR @%d ", _entry_bci);
> 
> 
> for OSR, Parsing is still recursive. In callee's Parse,  _entry_bci is InvocationEntryBci but C->is_osr_compilation() is true. 
> 
> if _entry_bci != InvocationEntryBci is true, it's only possible from 'depth() == 1 && C->is_osr_compilation())' above.

Got it, thanks for the clarification!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16669#discussion_r1400125604