RFR: 8320347: Emulate vblendvp[sd] on ECore [v2]

Jatin Bhateja jbhateja at openjdk.org
Tue Nov 21 18:36:20 UTC 2023


On Tue, 21 Nov 2023 17:44:11 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'jdk/master' into vp-ecore2
>>  - review comments
>>  - emulate vblend on ecores
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 3577:
> 
>> 3575:   if (EnableX86ECoreOpts && scratch_available && dst_available) {
>> 3576:     XMMRegister full_mask = mask;
>> 3577:     if (!fully_masked) {
> 
> name change suggestion for better understanding. fully_masked -> compute_mask

We can also remove full_mask register and directly update mask if compute mask is true.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1400957739


More information about the hotspot-compiler-dev mailing list