RFR: 8320347: Emulate vblendvp[sd] on ECore [v2]
Sandhya Viswanathan
sviswanathan at openjdk.org
Tue Nov 21 19:04:11 UTC 2023
On Tue, 21 Nov 2023 18:10:30 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'jdk/master' into vp-ecore2
>> - review comments
>> - emulate vblend on ecores
>
> src/hotspot/cpu/x86/x86.ad line 7840:
>
>> 7838: match(Set dst (VectorBlend (Binary src1 src2) mask));
>> 7839: format %{ "vector_blend $dst,$src1,$src2,$mask\t! using $vtmp as TEMP" %}
>> 7840: effect(TEMP vtmp, TEMP dst);
>
> TEMP dst can be removed.
TEMP dst is needed because otherwise register allocator can allocate dst and vtmp to be same. The vpand will then overwrite vtmp.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1401041831
More information about the hotspot-compiler-dev
mailing list