RFR: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from [v2]

Wed Nov 22 00:27:12 UTC 2023

On Wed, 22 Nov 2023 00:03:16 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   redo for x86
>
> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 3634:
> 
>> 3632: #ifdef ASSERT
>> 3633:   if (obj == tmp) {
>> 3634:     LP64_ONLY(assert_different_registers(obj, rscratch1, mdo_addr.base(), mdo_addr.index());)
> 
> I mind `#ifdef _LP64` more readable than `LP64_ONLY`/`NOT_LP64` here.

Moreover, any particular problems with unconditionally passing `rscratch1`? `rscratch1` is set to`noreg` on x86_32 and I believe `assert_different_registers` should handle it well if all other arguments are guaranteed to be valid registers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16750#discussion_r1401352843