RFR: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from [v2]

Wed Nov 22 00:52:25 UTC 2023

On Wed, 22 Nov 2023 00:10:34 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   redo for x86
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 58:
> 
>> 56: 
>> 57: #ifdef _LP64
>> 58:   assert_different_registers(obj, rscratch1, mdo_addr.base(), mdo_addr.index());
> 
> Same here: pass `rscratch1` unconditionally?

Unfortunately, I don't know if mdo_addr.index() is a register.  I wish we had a smarter assert_different_registers() that would ignore multiple `noreg`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16750#discussion_r1401376444