RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v3]

Wed Nov 22 02:21:07 UTC 2023

On Tue, 21 Nov 2023 15:07:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add _sve_xunpk & remove dead code
>>   
>>   Change-Id: Ic19836feb8a73ea7e65443794f2a0eb1363f6e2f
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1412:
> 
>> 1410:       _sve_xunpk(is_unsigned, /* is_high */ false, dst, S, dst);
>> 1411:       _sve_xunpk(is_unsigned, /* is_high */ false, dst, D, dst);
>> 1412:       break;
> 
> Why is this change here? It doesn't do anything. Does it?

`is_unsigned` is also used in this function. It is used in VectorUCastNode for zero extending.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16670#discussion_r1401423194